Skip to content

BuildInfo: convert fields from String to Text - #12436

Merged
mergify[bot] merged 1 commit into
masterfrom
text-in-buildinfo
Oct 16, 2026
Merged

mergify[bot] merged 1 commit into
masterfrom
text-in-buildinfo

Conversation

@Bodigrim

@Bodigrim Bodigrim commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Continuing #12350, migrate yet another piece of Cabal-syntax from String to Text.

At this stage it's a bunch of conversions back and forth, but at least it should be straightforward and not too big to review. I'll clean up the amount of conversions in subsequent PRs.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@Bodigrim
Bodigrim marked this pull request as ready for review October 10, 2026 13:42
Comment thread Cabal/src/Distribution/Simple/Program/GHC.hs Outdated
Comment thread Cabal/src/Distribution/Simple/GHCJS.hs Outdated
Comment thread Cabal/src/Distribution/Simple/GHC/Build/Modules.hs Outdated
Comment thread Cabal-syntax/src/Distribution/PackageDescription/FieldGrammar.hs Outdated
Comment thread cabal-install/src/Distribution/Client/ScriptUtils.hs Outdated
Comment thread changelog.d/pr-12436.md Outdated
@Bodigrim Bodigrim added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 12, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 12, 2026
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Oct 16, 2026
@mergify

mergify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-10-16 19:57 UTC · Rule: default · triggered by rule Put pull requests in the rebase+merge queue
  • ✅ Checks passed · on draft merge queue: checking #12436 on master (2778966) #12469
  • ✅ Merged — 2026-10-16 22:09 UTC · at aeac769ebf7ff5e2d72051bbcb319d94f03f8617 · merge

This pull request spent 2 hours 12 minutes 3 seconds in the queue, including 2 hours 41 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify mergify Bot mentioned this pull request Oct 16, 2026
44 of 84 tasks
@mergify
mergify Bot merged commit aeac769 into master Oct 16, 2026
87 of 89 checks passed
@mergify
mergify Bot deleted the text-in-buildinfo branch October 16, 2026 22:09
@mergify mergify Bot removed the queued label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants